Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a nice homepage #7

Open
CrowdHailer opened this issue Oct 31, 2017 · 4 comments
Open

Create a nice homepage #7

CrowdHailer opened this issue Oct 31, 2017 · 4 comments
Labels
enhancement good first issue

Comments

@CrowdHailer
Copy link
Owner

The homepage template is incredibly bare bone.
https://github.com/CrowdHailer/elixir-on-docker/blob/master/www/lib/www/home_page.html.eex

It should be extended and receive some simple styling.
@ODAVING
Copy link

ODAVING commented Oct 10, 2019

Mind if I worked on this? fairly new to open source, so any requirements you'd like added I'd try and implement it

ODAVING added a commit to ODAVING/elixir-on-docker that referenced this issue Oct 10, 2019
@ODAVING
front-end(HTML): Custom home page
d09249a 
Custom homepage was added to take away the plain "Hello World" webpage

Closes issue CrowdHailer#7
@ODAVING ODAVING mentioned this issue Oct 10, 2019
Open
@CrowdHailer
Copy link
Owner Author

Hi, nice to here from you. Go for it.

perhaps for some context, I should mention I am not actively working on this project. You might be intersted in looking at raxx_kit. that is a project generator that also has a docker option.

@ODAVING
Copy link

ODAVING commented Oct 11, 2019

Oh I see, I'll take a look at that project as well. Let me know how you feel about the PR I did for this, and if you would like any revisions :)

ODAVING added a commit to ODAVING/elixir-on-docker that referenced this issue Oct 11, 2019
@ODAVING
front-end(HTML): Custom home page
b46e210 
Custom homepage was added to take away the plain "Hello World" webpage

Closes issue CrowdHailer#7

Fixed minor HTML mistakes
@CrowdHailer
Copy link
Owner Author

Hi, thanks for the PR.
Because it's such a small page I would rather we didn't have to use any JS or rely on assets from CDN's, relying on the wild internet means that local development is messed up if you don't have the internet. I'm often working on a train and it's just not good to use the WiFi.

If you were to find a smaller CSS framework such that it could be added to the project that would be an approach which I think would fit better for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CrowdHailer @ODAVING