Fix 1.21.1 server side starting issues #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove empty DEDICATED_SERVER handler causing trouble on starting 1.21.1 servers
JackTWing
approved these changes
Mar 23, 2025
|
LGTM, sorry for the late response on review. (will merge after testing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently 21.1.* NeoForge versions (compatible with 1.21.1 server/client) do not take well empty event handlers, or at least without a @SubscribeEvent method.
I searched for implementations of what would be the FMLServerStartingEvent or FMLServerAboutToStartEvent to have at least an empty method listening to them, but couldn't find any.
As the class
ESEventHandlerServerwas empty, I assume that there are no server sided events that are relevant to the mod now, and to allow the players to boot the servers, simply removing it would do.I have no experience with Minecraft modding though and my Java is quite rusty.
Let me know if you need more changes to it.
The base repo also doesn't have a 1.21.1 branch, so I'm happy to change it target that once it's created/