Draft
Conversation
bab0e8d to
c998e9b
Compare
Author
|
I also slightly refactored # snip
if not os.path.exists(Settings.editor_temp_root):
os.mkdir(Settings.editor_temp_root)
# snapBut shouldn't it be |
f5e8926 to
71d7a6b
Compare
71d7a6b to
d4bf903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Are you accepting contributions for this?
Is this going in the right direction? I thought it'd be good to first change the internal path-handling to use
pathliband then deal with passing the paths around aspathlib.Pathobjects instead of strings.Resolves #23 .