Skip to content

Commit db548b4

Browse files
authored
Merge pull request #496 from jorgeblacio/refresh_token_fix
Fixed an issue when parsing the response of refreshToken.
2 parents d7f15cb + 595a5f3 commit db548b4

File tree

5 files changed

+25
-15
lines changed

5 files changed

+25
-15
lines changed

NotificationExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<key>CFBundleShortVersionString</key>
2020
<string>$(MARKETING_VERSION)</string>
2121
<key>CFBundleVersion</key>
22-
<string>1</string>
22+
<string>$(CURRENT_PROJECT_VERSION)</string>
2323
<key>NSExtension</key>
2424
<dict>
2525
<key>NSExtensionPointIdentifier</key>

ShareExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<key>CFBundleShortVersionString</key>
2020
<string>$(MARKETING_VERSION)</string>
2121
<key>CFBundleVersion</key>
22-
<string>1</string>
22+
<string>$(CURRENT_PROJECT_VERSION)</string>
2323
<key>NSExtension</key>
2424
<dict>
2525
<key>NSExtensionAttributes</key>

iOS-Email-Client.xcodeproj/project.pbxproj

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2777,6 +2777,7 @@
27772777
CODE_SIGN_IDENTITY = "iPhone Developer";
27782778
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
27792779
CODE_SIGN_STYLE = Automatic;
2780+
CURRENT_PROJECT_VERSION = 2;
27802781
DEVELOPMENT_TEAM = 65NU4336S4;
27812782
FRAMEWORK_SEARCH_PATHS = (
27822783
"$(inherited)",
@@ -2818,6 +2819,7 @@
28182819
CODE_SIGN_IDENTITY = "iPhone Developer";
28192820
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
28202821
CODE_SIGN_STYLE = Automatic;
2822+
CURRENT_PROJECT_VERSION = 2;
28212823
DEVELOPMENT_TEAM = 65NU4336S4;
28222824
FRAMEWORK_SEARCH_PATHS = (
28232825
"$(inherited)",
@@ -2964,6 +2966,7 @@
29642966
CODE_SIGN_IDENTITY = "iPhone Developer";
29652967
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
29662968
CODE_SIGN_STYLE = Automatic;
2969+
CURRENT_PROJECT_VERSION = 2;
29672970
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
29682971
DEVELOPMENT_TEAM = 65NU4336S4;
29692972
FRAMEWORK_SEARCH_PATHS = (
@@ -3028,6 +3031,7 @@
30283031
CODE_SIGN_IDENTITY = "iPhone Developer";
30293032
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
30303033
CODE_SIGN_STYLE = Automatic;
3034+
CURRENT_PROJECT_VERSION = 2;
30313035
DEVELOPMENT_TEAM = 65NU4336S4;
30323036
FRAMEWORK_SEARCH_PATHS = (
30333037
"$(inherited)",
@@ -3058,6 +3062,7 @@
30583062
CODE_SIGN_IDENTITY = "iPhone Developer";
30593063
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
30603064
CODE_SIGN_STYLE = Automatic;
3065+
CURRENT_PROJECT_VERSION = 2;
30613066
DEVELOPMENT_TEAM = 65NU4336S4;
30623067
FRAMEWORK_SEARCH_PATHS = (
30633068
"$(inherited)",
@@ -3087,6 +3092,7 @@
30873092
CODE_SIGN_IDENTITY = "iPhone Developer";
30883093
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
30893094
CODE_SIGN_STYLE = Automatic;
3095+
CURRENT_PROJECT_VERSION = 2;
30903096
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
30913097
DEVELOPMENT_TEAM = 65NU4336S4;
30923098
FRAMEWORK_SEARCH_PATHS = (
@@ -3119,6 +3125,7 @@
31193125
CODE_SIGN_IDENTITY = "iPhone Developer";
31203126
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
31213127
CODE_SIGN_STYLE = Automatic;
3128+
CURRENT_PROJECT_VERSION = 2;
31223129
DEVELOPMENT_TEAM = 65NU4336S4;
31233130
FRAMEWORK_SEARCH_PATHS = (
31243131
"$(inherited)",
@@ -3152,6 +3159,7 @@
31523159
CODE_SIGN_IDENTITY = "iPhone Developer";
31533160
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
31543161
CODE_SIGN_STYLE = Automatic;
3162+
CURRENT_PROJECT_VERSION = 2;
31553163
DEVELOPMENT_TEAM = 65NU4336S4;
31563164
FRAMEWORK_SEARCH_PATHS = (
31573165
"$(inherited)",
@@ -3184,6 +3192,7 @@
31843192
CODE_SIGN_IDENTITY = "iPhone Developer";
31853193
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
31863194
CODE_SIGN_STYLE = Automatic;
3195+
CURRENT_PROJECT_VERSION = 2;
31873196
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
31883197
DEVELOPMENT_TEAM = 65NU4336S4;
31893198
FRAMEWORK_SEARCH_PATHS = (

iOS-Email-Client/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
</dict>
3131
</array>
3232
<key>CFBundleVersion</key>
33-
<string>1</string>
33+
<string>$(CURRENT_PROJECT_VERSION)</string>
3434
<key>Fabric</key>
3535
<dict>
3636
<key>APIKey</key>

iOS-Email-Client/Shared/SharedAPI.swift

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -133,20 +133,21 @@ class SharedAPI {
133133
versionHeader: apiVersion
134134
]
135135

136-
Alamofire.request(url, method: .get, parameters: nil, encoding: JSONEncoding.default, headers: headers).responseJSON(queue: queue) { (response) in
136+
Alamofire.request(url, method: .get, parameters: nil, encoding: JSONEncoding.default, headers: headers).responseString(queue: queue) { (response) in
137137
let refreshResponseData = handleResponse(response)
138138
switch (refreshResponseData) {
139-
case .SuccessString(let newJwt):
140-
SharedDB.update(oldJwt: token, jwt: newJwt)
141-
SharedDB.refresh()
142-
completionHandler(nil, newJwt)
143-
break
144-
case .SuccessDictionary(let data):
145-
let newJwt = data["token"] as! String
146-
let newRefreshToken = data["refreshToken"] as! String
147-
SharedDB.update(oldJwt: token, jwt: newJwt, refreshToken: newRefreshToken)
148-
SharedDB.refresh()
149-
completionHandler(nil, newJwt)
139+
case .SuccessString(let data):
140+
if let jsonData = Utils.convertToDictionary(text: data) {
141+
let newJwt = jsonData["token"] as! String
142+
let newRefreshToken = jsonData["refreshToken"] as! String
143+
SharedDB.update(oldJwt: token, jwt: newJwt, refreshToken: newRefreshToken)
144+
SharedDB.refresh()
145+
completionHandler(nil, newJwt)
146+
} else {
147+
SharedDB.update(oldJwt: token, jwt: data)
148+
SharedDB.refresh()
149+
completionHandler(nil, data)
150+
}
150151
break
151152
default:
152153
completionHandler(refreshResponseData, token)

0 commit comments

Comments
 (0)