Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open URL directly instead of using a Safari view controller #76

Closed
nathanfallet opened this issue Apr 25, 2021 · 2 comments
Closed

Open URL directly instead of using a Safari view controller #76

nathanfallet opened this issue Apr 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@nathanfallet
Copy link
Member

let safariViewController = SFSafariViewController(url: url, configuration: config)

Opening the URL directly here would allow to open the app of the website if installed.
Also, I thing it's way more comfortable to browse it in safari than in a view controller in the app.

See this conversation:
image

@nathanfallet nathanfallet added the enhancement New feature or request label Apr 25, 2021
@PlugNPush
Copy link
Collaborator

Are you sure that an SFSafariViewController prevents App Links to operate?

@PlugNPush
Copy link
Collaborator

@nathanfallet it seems like the URL used for Doctolib is partners.doctolib.fr, which is not declared for App Links. To be verified, but this wouldn't have any effect on the UX.

@nathanfallet nathanfallet closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants