Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an internal Swift package #51

Open
florentmorin opened this issue Apr 21, 2021 · 2 comments
Open

Use an internal Swift package #51

florentmorin opened this issue Apr 21, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request suggestion This idea is a suggestion, and is not approved yet. Please don't try to fix it now
Milestone

Comments

@florentmorin
Copy link

Without changing lots of code, performances (runtime, compilation), security and quality can be improved with an internal Swift package.
It can also helps to easily share code with potential extensions.

@nathanfallet
Copy link
Member

Not sure it will be useful. If we need to share code with extensions, we can include a file in multiple targets directly.

@victor-sarda victor-sarda added the enhancement New feature or request label Apr 21, 2021
@PlugNPush
Copy link
Collaborator

I think that for the usage we currently have, which is an expanding, just launched app, an Internal Swift Package would potentially even be worse to work in an efficient manner.

@nathanfallet nathanfallet added the suggestion This idea is a suggestion, and is not approved yet. Please don't try to fix it now label Apr 23, 2021
@nathanfallet nathanfallet changed the title [Suggestion] Use an internal Swift package Use an internal Swift package Apr 23, 2021
@victor-sarda victor-sarda added this to the 1.5.1 milestone Jan 24, 2022
@victor-sarda victor-sarda self-assigned this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request suggestion This idea is a suggestion, and is not approved yet. Please don't try to fix it now
Projects
Development

No branches or pull requests

4 participants