Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspend alternative propensity calculation 'form's #27

Closed
jmason42 opened this issue Dec 21, 2018 · 2 comments
Closed

Suspend alternative propensity calculation 'form's #27

jmason42 opened this issue Dec 21, 2018 · 2 comments
Labels
question Further information is requested

Comments

@jmason42
Copy link
Contributor

Playing with Numba - I don't think it likes passing around function handles. I get performance hits when trying to wrap propensity and choose with @numba.jit, but if I pull out the form option, I get roughly a four-fold speed-up. There's probably a way around this but I think it's going to be easier to step back before moving forward - we also don't have any non-default test cases for the form feature. @prismofeverything thoughts?

(Numba FAQs suggest that this is an active area for improvement.)
@jmason42 jmason42 added the question Further information is requested label Dec 21, 2018
@prismofeverything
Copy link
Member

Yeah I'm happy to walk back the form feature if it is holding us back, feel free! It was for a feature Heejo needed, but it turns out she doesn't need it anymore

@jmason42
Copy link
Contributor Author

Addressed via #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prismofeverything @jmason42