Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #146

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Typo #146

merged 1 commit into from
Feb 9, 2016

Conversation

bobmulder
Copy link
Contributor

I am not english, but I think it should be 'turns' (he, she, it rule ;))

I am not english, but I think it should be 'turns' (he, she, it rule ;))
@mnapoli
Copy link
Member

mnapoli commented Feb 9, 2016

Thanks!

mnapoli added a commit that referenced this pull request Feb 9, 2016
@mnapoli mnapoli merged commit 10cb7fa into CouscousPHP:master Feb 9, 2016
@bobmulder
Copy link
Contributor Author

Travis fails? :(

@wysow
Copy link
Member

wysow commented Feb 9, 2016

@bobmulder Nope, @mnapoli is just too fast when merging typos ;)

@mnapoli
Copy link
Member

mnapoli commented Feb 9, 2016

👍 quick merge to sweep the typo under the rug :p

@bobmulder
Copy link
Contributor Author

Just curious, I see that the docs are not generated automatically?

@mnapoli
Copy link
Member

mnapoli commented Feb 9, 2016

All good now: http://couscous.io/ (I wasn't able to update them earlier today)

Indeed they are not generated automatically because we embed couscous.phar on the website, so we don't want to build it everytime a commit happens on master else we would be deploying dev versions. We would need a more clever release script running on Travis, but it's probably not the simplest to write and nobody has done it yet. I'm fine releasing/updating the website manually for now.

@mnapoli mnapoli added this to the 1.5 milestone Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants