Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc api final #287

Merged
merged 17 commits into from
Sep 27, 2022
Merged

Rc api final #287

merged 17 commits into from
Sep 27, 2022

Conversation

turtledreams
Copy link
Contributor

tested

@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2022

This pull request fixes 1 alert when merging b6dcf19 into 91a3d75 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh mah gadh

no changelog
no sample usage

@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2022

This pull request fixes 1 alert when merging d329dba into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2022

This pull request fixes 1 alert when merging bf1a872 into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request fixes 1 alert when merging 52c9638 into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request fixes 1 alert when merging a0fdee9 into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request fixes 1 alert when merging e8d3c68 into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"rc_automatic_optin_for_ab" instead of "rc_optin"

"useExplicitRcApi" instead of "useRcApi"

"use_explicit_rc_api" instead of "use_new_rc_api"

@ArtursKadikis ArtursKadikis merged commit 250e07e into staging Sep 27, 2022
@ArtursKadikis ArtursKadikis deleted the rc_api_final branch September 27, 2022 12:25
@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request fixes 1 alert when merging 2489703 into 030fdca - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants