[Draft] v30: Feemarket, Scalar UI, Cleanup #1162
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| protoiface "google.golang.org/protobuf/runtime/protoiface" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| io "io" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
|
|
||
| // handle tx priority | ||
| var priority int64 = 0 | ||
| bondDenomGasPrice, err := dfd.feemarketKeeper.GetCurrentGasPrice(ctx, dfd.bondDenom) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the issue, the assignment to err on line 160 should be removed entirely. This eliminates the redundant operation and ensures that the code is cleaner and easier to understand. The subsequent assignment to err on line 161 remains intact, as it is used later in the code.
| @@ -159,3 +159,3 @@ | ||
| var priority int64 = 0 | ||
| bondDenomGasPrice, err := dfd.feemarketKeeper.GetCurrentGasPrice(ctx, dfd.bondDenom) | ||
| bondDenomGasPrice := dfd.feemarketKeeper.GetCurrentGasPrice(ctx, dfd.bondDenom) | ||
| priorityFee, err := dfd.resolveTxPriorityCoins(ctx, payCoin, dfd.bondDenom) |
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This PR includes the following changes made for the Juno v30 software upgrade:
Replaced broken cosmos sdk swagger implementation with OpenAPI 3.0 compatible Scalar UI on every node. Access it by enabling the api server in your node config and navigating to :1317/scalar
Massively cleaned up proto generation and adjusted the flow to allow for above changes
Updated to Cosmos SDK 0.53.0 and accompanying modules and dependency bumps
Removed x/globalfee module
Forked deprecated x/feemarket by ICL/Skip, adjusted and implemented
Reworked interchaintest e2e suite for much better scalability