Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabBar can't set tab bar items in Objective-C #911

Closed
markst opened this issue Oct 16, 2017 · 5 comments
Closed

TabBar can't set tab bar items in Objective-C #911

markst opened this issue Oct 16, 2017 · 5 comments
Assignees
@daniel-jonathan
Labels
enhancement fix

Comments

@markst
Copy link
Contributor

markst commented Oct 16, 2017

No description provided.

@markst
Copy link
Contributor Author

markst commented Oct 16, 2017

Property needs @objc prefix:

@objc open var tabItems = [TabItem]() {

@markst
Copy link
Contributor Author

markst commented Oct 16, 2017

Also unable to set attributes:

image

@daniel-jonathan daniel-jonathan self-assigned this Oct 16, 2017
@daniel-jonathan
Copy link
Member

daniel-jonathan commented Oct 16, 2017 •
edited
Loading

So it looks like now Obj-C requires this addition for Swift 4. I pushed a version now that adds the @objc to the tabItems, Material 2.12.1. Please verify this works for you and I will add the remaining @objc where necessary.

@markst markst mentioned this issue Oct 17, 2017
Merged
@markst
Copy link
Contributor Author

markst commented Oct 17, 2017

@DanielDahan cheers daniel. changes has worked.

@daniel-jonathan
Copy link
Member

The associated PR for this #914.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement fix
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markst @daniel-jonathan