Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageTabBarController's indicator line bounce problem #768

Closed
okankocyigit opened this issue May 31, 2017 · 3 comments · Fixed by #769
Closed

PageTabBarController's indicator line bounce problem #768

okankocyigit opened this issue May 31, 2017 · 3 comments · Fixed by #769
Assignees

Comments

@okankocyigit
Copy link
Contributor

https://drive.google.com/file/d/0B5L3zd-GHgiFYl95OVFWcXlydkE/view

When I just make three tabs it works as expected without bouncing.

@okankocyigit
Copy link
Contributor Author

I couldn't get the point of this line,

let x = (scrollView.contentOffset.x - view.width) / scrollView.contentSize.width * view.width
pageTabBar.line.center.x = selected.center.x + x

there might be a bug, I've also tried it on Material Samples, when I increase tab count more then three it starts animating indicator wrongly.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented May 31, 2017

I will give this a look. I noticed your PR fixing the issue as well. Thank you :)

@daniel-jonathan
Copy link
Member

This component has now been updated in Material 2.8.0. Features like swiping have not been included in 2.8.0, and will be included in a following release. The overall TabsController adds stability and scrollable Tabs. I am closing this issue and thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants