Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit event types #440

Closed
alpe opened this issue Mar 5, 2021 · 2 comments · Fixed by #586
Closed

Revisit event types #440

alpe opened this issue Mar 5, 2021 · 2 comments · Fixed by #586
Labels
enhancement New feature or request events
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Mar 5, 2021

We emit events of type sdk.EventTypeMessage mostly. They could become more useful with specific types.

@alpe alpe added the enhancement New feature or request label Mar 5, 2021
@alpe alpe added this to the v0.17.0 milestone Mar 5, 2021
@ethanfrey
Copy link
Member

Nice idea, the TypedEvent stuff, right?

I saw this as I was parsing the abci.Events returned when dispatching an sdk.Msg and passing them to the EventManager and wondering why the method was deprecated. It would be good to use this for the ones we generate manually.

@alpe
Copy link
Contributor Author

alpe commented Mar 9, 2021

Sorry, I should have been more precise. This is not about the deprecated method but the string we pass as first argument https://github.com/CosmWasm/wasmd/blob/v0.15.1/x/wasm/internal/keeper/msg_server.go#L33 .
If we would use more concrete types like "contract_stored" instead of "message" then it would be easier for a client to subscribe to the right one.
I found some good example in the distribution module

Ref sdk-events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request events
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants