Fix

Author: chipshort

x/wasm/ibc_integration_test.go

@@ -288,10 +288,10 @@ func TestIBCAsyncAck(t *testing.T) {
 		path              = wasmibctesting.NewPath(chainA, chainB)
 	)
 	path.EndpointA.ChannelConfig = &ibctesting.ChannelConfig{
-		PortID: sourcePortID, Version: "ibc-reflect-v1", Order: channeltypes.UNORDERED,
+		PortID: sourcePortID, Version: "ibc-reflect-v1", Order: channeltypes.ORDERED,
 	}
 	path.EndpointB.ChannelConfig = &ibctesting.ChannelConfig{
-		PortID: counterpartPortID, Version: "ibc-reflect-v1", Order: channeltypes.UNORDERED,
+		PortID: counterpartPortID, Version: "ibc-reflect-v1", Order: channeltypes.ORDERED,
 	}
 
 	coord.SetupConnections(path)

x/wasm/keeper/relay.go

@@ -40,13 +40,19 @@ func (k Keeper) OnOpenChannel(
 	gasLeft := k.runtimeGasForContract(ctx)
 	res, gasUsed, execErr := k.wasmVM.IBCChannelOpen(codeInfo.CodeHash, env, msg, prefixStore, cosmwasmAPI, querier, ctx.GasMeter(), gasLeft, costJSONDeserialization)
 	k.consumeRuntimeGas(ctx, gasUsed)
-	if execErr != nil {
+	switch {
+	case execErr != nil:
 		return "", errorsmod.Wrap(types.ErrExecuteFailed, execErr.Error())
-	}
-	if res != nil && res.Ok != nil {
-		return res.Ok.Version, nil
-	}
-	return "", nil
+	case res == nil:
+		return "", errorsmod.Wrap(types.ErrVMError, "empty response from contract")
+	case res.Err != "":
+		return "", types.MarkErrorDeterministic(errorsmod.Wrap(types.ErrExecuteFailed, res.Err))
+	case res.Ok == nil:
+		// a nil "ok" value is a valid response and means the contract accepts the incoming channel version
+		// see https://docs.rs/cosmwasm-std/2.2.2/cosmwasm_std/type.IbcChannelOpenResponse.html
+		return "", nil
+	}
+	return res.Ok.Version, nil
 }
 
 // OnConnectChannel calls the contract to let it know the IBC channel was established.