Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniqueIndex / MultiIndex key consistency #532

Closed
maurolacy opened this issue Nov 4, 2021 · 1 comment · Fixed by #568
Closed

UniqueIndex / MultiIndex key consistency #532

maurolacy opened this issue Nov 4, 2021 · 1 comment · Fixed by #568
Assignees
@maurolacy
Labels
breaking Breaking changes High Priority storage plus
Milestone
v0.11.0

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Nov 4, 2021 •
edited
Loading

Unify the key returned by UniqueIndex and MultiIndex.

Currently, UniqueIndex returns just the pk, whereas MultiIndex returns the remaining of the key, including the pk as last element. Either make both return just the pk, or make UniqueIndex behave like MultiIndex (which is better for usability / options). (opted for the first option, for simplicity).

There are a number of FIXMEs in the code where this needs to be changed.
@maurolacy maurolacy mentioned this issue Nov 4, 2021
Merged
@maurolacy maurolacy added this to the v0.11.0 milestone Dec 1, 2021
@maurolacy
Copy link
Contributor Author

As this is breaking, let's do it for 0.11, along with #460.

@maurolacy maurolacy added the breaking Breaking changes label Dec 1, 2021
@maurolacy maurolacy self-assigned this Dec 1, 2021
@maurolacy maurolacy mentioned this issue Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
breaking Breaking changes High Priority storage plus
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Index keys consistency CosmWasm/cw-plus
1 participant
@maurolacy