-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rust to 1.53 #372
Comments
What kind of upgrade are you thingking about? I think there are two questions:
But you can also simply silence the warning at that place and add a comment why you did it. |
I know I can just allow the warning, I will do that for now. However as this is fixed already, I don't see a reason why not to bump whole ecosystem version to 1.53 (the newest stable is 1.54 so it seems to be matching minimum supported version as it should be at least one release before newest stable). |
The reason is: we take as much burden as we can on us to avoid any unnecessary disruption of our users (=contract developers), that might be happily compiling with an older version. |
Ok, reasonable. Do we consider add a |
The problem I have with It should not be too hard to keep the project compatible for the range MSRV-latest stable. MSRV here can be defined differently than in cosmwasm if it helps. |
Working on PR #369 I faced clippy false positive:
However in this context signature has to be as it is, as the function is later passed as an argument to
impl Fn
of specific signature. This is handled properly in clippy 1.53.@webmaster128 can we perform such an upgrade?
The text was updated successfully, but these errors were encountered: