Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust to 1.53 #372

Closed
hashedone opened this issue Aug 3, 2021 · 5 comments · Fixed by #379
Closed

Upgrade rust to 1.53 #372

hashedone opened this issue Aug 3, 2021 · 5 comments · Fixed by #379
Milestone

Comments

@hashedone
Copy link
Contributor

hashedone commented Aug 3, 2021

Working on PR #369 I faced clippy false positive:

error: this function's return value is unnecessarily wrapped by Result

However in this context signature has to be as it is, as the function is later passed as an argument to impl Fn of specific signature. This is handled properly in clippy 1.53.

@webmaster128 can we perform such an upgrade?

@webmaster128
Copy link
Member

What kind of upgrade are you thingking about? I think there are two questions:

But you can also simply silence the warning at that place and add a comment why you did it.

@hashedone
Copy link
Contributor Author

I know I can just allow the warning, I will do that for now. However as this is fixed already, I don't see a reason why not to bump whole ecosystem version to 1.53 (the newest stable is 1.54 so it seems to be matching minimum supported version as it should be at least one release before newest stable).

@webmaster128
Copy link
Member

The reason is: we take as much burden as we can on us to avoid any unnecessary disruption of our users (=contract developers), that might be happily compiling with an older version.

@hashedone
Copy link
Contributor Author

Ok, reasonable. Do we consider add a toolchain.toml file to make it also easier for developers? I mean I obviously can just override my version but it requires every single dev to keep in mind syncing version he is using with a version supported for contracts, and toolchain file seems to solve that.

@webmaster128
Copy link
Member

The problem I have with toolchain.toml is that it enforces version pinning, which downgrades the compiler version in many cases. I don't want to use an old compiler, just because the project has a relatively low MSRV.

It should not be too hard to keep the project compatible for the range MSRV-latest stable. MSRV here can be defined differently than in cosmwasm if it helps.

@ethanfrey ethanfrey added this to the v0.8.0 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants