-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Uint128
inner field private
#946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the update to ensure the CHANGELOG entry is at the right place.
47d1ade
to
df039dd
Compare
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just the merge conflict and running the markdown text formatter.
CHANGELOG.md
Outdated
- cosmwasm-std: Fix `Uint64::multiply_ratio` and `Uint128::multiply_ratio` so | ||
that internal multiplication cannot cause an unnecessary overflow. ([#920]) | ||
- cosmwasm-std: Fix `Uint64::multiply_ratio` and `Uint128::multiply_ratio` | ||
so that internal multiplication cannot cause an unnecessary overflow. ([#920]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "so" was moved up by my because of the text formatter (See ./devtools/format_md.sh
and #951)
Want to merge #945 first? I think it will cause another conflict. |
Closes #905