Make Uint128 inner field private
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint
force-pushed
the
uint128-private-inner-value
branch
from
47d1ade
to
df039dd
Compare
|
Rebased! |
CHANGELOG.md
Outdated
| - cosmwasm-std: Fix `Uint64::multiply_ratio` and `Uint128::multiply_ratio` so | ||
| that internal multiplication cannot cause an unnecessary overflow. ([#920]) | ||
| - cosmwasm-std: Fix `Uint64::multiply_ratio` and `Uint128::multiply_ratio` | ||
| so that internal multiplication cannot cause an unnecessary overflow. ([#920]) |
There was a problem hiding this comment.
This "so" was moved up by my because of the text formatter (See ./devtools/format_md.sh and #951)
Want to merge #945 first? I think it will cause another conflict. |
webmaster128
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #905