Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BankMsg::Burn to CosmosMsg #845

Closed
ethanfrey opened this issue Mar 16, 2021 · 2 comments · Fixed by #860
Closed

Add BankMsg::Burn to CosmosMsg #845

ethanfrey opened this issue Mar 16, 2021 · 2 comments · Fixed by #860
Milestone

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Mar 16, 2021

A dev wanted to add this as a custom callback, but I think this would be better to add directly to Bank.

#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)]
#[serde(rename_all = "snake_case")]
pub enum BankMsg {
    Send {
        to_address: HumanAddr,
        amount: Vec<Coin>,
    },
    Burn {
        amount: Vec<Coin>,
    },
}
@webmaster128
Copy link
Member

Where is this implemented in the SDK? The bank module does not seem to have a message type like this: https://github.com/cosmos/cosmos-sdk/blob/v0.42.1/proto/cosmos/bank/v1beta1/tx.proto#L10-L17

@ethanfrey
Copy link
Member Author

No there is no such message. There is also no sdk message equivalent to IbcMsg::SendPacket (we need to call the keepers directly).

However, this has been requested before and the functionality is exposed on the bank keeper: https://docs.cosmos.network/master/modules/bank/02_keepers.html#basekeeper

@ethanfrey ethanfrey mentioned this issue Apr 7, 2021
@mergify mergify bot closed this as completed in #860 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants