Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Remove Snapshot merging / legacy Code? #43

Open
lephisto opened this issue Jan 31, 2020 · 6 comments
Open

[Discussion] Remove Snapshot merging / legacy Code? #43

lephisto opened this issue Jan 31, 2020 · 6 comments

Comments

@lephisto
Copy link
Contributor

Since there are currently two approaches in the Codebase, I want to discuss if you want to keep the ability to merge snapshots into each other. I personally wouldn't dare to go on and take one Base Snapshot in a year, and then only merge onto it. And: There's no way to merge into the Basecopy, so the volatile data would accumulate in the first Differential file after the Basecopy.

@franklupo
Copy link
Member

what do you propose?

@franklupo
Copy link
Member

Add option --disable-merge-snapshot to disable merge.

@lephisto
Copy link
Contributor Author

lephisto commented Feb 1, 2020

There's no need to do, because it won't merge snapshots in --renew mode. in --keep mode it does behave like it always did.

@franklupo
Copy link
Member

What idea do you have for this?

@lephisto
Copy link
Contributor Author

The idea was to compeltely remove all merge logic since it you might not detect if something goes wrong until you try to restore stuff. For now let's keep it in, and keep backwards compatibility..

@franklupo
Copy link
Member

Ok for me good idea remove all merge logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants