Skip to content

Fix ULF detection in Claude licensing #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 1 commit into from
Jan 15, 2026
Merged

Fix ULF detection in Claude licensing #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/claude-nl-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,20 @@ jobs:
printf "%s" "$UNITY_LICENSE" > "$f"
fi
chmod 600 "$f" || true
# Detect ULF first; it is XML and includes a <Signature> element.
if grep -qi '<Signature>' "$f"; then
# provide it in the standard local-share path too
cp -f "$f" "$RUNNER_TEMP/unity-local/Unity/Unity_lic.ulf"
echo "License source: ULF (Signature found)"
echo "ok=true" >> "$GITHUB_OUTPUT"
# If someone pasted an entitlement XML into UNITY_LICENSE by mistake, re-home it:
if head -c 100 "$f" | grep -qi '<\?xml'; then
elif grep -qi 'Entitlement|entitlement' "$f"; then
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The grep pattern 'Entitlement|entitlement' is treated literally and won’t match either word as intended.

In basic grep (without -E), | is treated literally, so this condition only matches Entitlement|entitlement and will miss actual entitlement XMLs. If you want case-insensitive matching on the word, use grep -qi 'entitlement' "$f" (relying on -i), or enable extended regex with -E and adjust the pattern accordingly.

mkdir -p "$RUNNER_TEMP/unity-config/Unity/licenses"
mv "$f" "$RUNNER_TEMP/unity-config/Unity/licenses/UnityEntitlementLicense.xml"
echo "License source: Entitlement XML (re-homed)"
echo "ok=false" >> "$GITHUB_OUTPUT"
elif grep -qi '<Signature>' "$f"; then
# provide it in the standard local-share path too
cp -f "$f" "$RUNNER_TEMP/unity-local/Unity/Unity_lic.ulf"
echo "ok=true" >> "$GITHUB_OUTPUT"
else
echo "License source: Unknown format (no ULF Signature or Entitlement markers)"
echo "ok=false" >> "$GITHUB_OUTPUT"
fi

Expand Down