Fix based on CR

Author: Scriptwonder

CustomTools/RoslynRuntimeCompilation/ManageRuntimeCompilation.cs

@@ -84,7 +84,10 @@ private static object CompileAndLoad(JObject @params)
             try
             {
                 string code = @params["code"]?.ToString();
-                string assemblyName = @params["assembly_name"]?.ToString() ?? $"DynamicAssembly_{DateTime.Now.Ticks}";
+                var assemblyToken = @params["assembly_name"];
+                string assemblyName = assemblyToken == null || string.IsNullOrWhiteSpace(assemblyToken.ToString())
+                    ? $"DynamicAssembly_{DateTime.Now.Ticks}"
+                    : assemblyToken.ToString().Trim();
                 string attachTo = @params["attach_to"]?.ToString();
                 bool loadImmediately = @params["load_immediately"]?.ToObject<bool>() ?? true;
 
@@ -101,8 +104,21 @@ private static object CompileAndLoad(JObject @params)
 
                 // Create output directory
                 Directory.CreateDirectory(DynamicAssembliesPath);
-                string dllPath = Path.Combine(DynamicAssembliesPath, $"{assemblyName}.dll");
-                
+                string basePath = Path.GetFullPath(DynamicAssembliesPath);
+                Directory.CreateDirectory(basePath);
+                string safeFileName = SanitizeAssemblyFileName(assemblyName);
+                string dllPath = Path.GetFullPath(Path.Combine(basePath, $"{safeFileName}.dll"));
+
+                if (!dllPath.StartsWith(basePath, StringComparison.Ordinal))
+                {
+                    return Response.Error("Assembly name must resolve inside the dynamic assemblies directory.");
+                }
+
+                if (File.Exists(dllPath))
+                {
+                    dllPath = Path.GetFullPath(Path.Combine(basePath, $"{safeFileName}_{DateTime.Now.Ticks}.dll"));
+                }
+
                 // Parse code
                 var syntaxTree = CSharpSyntaxTree.ParseText(code);
 
@@ -121,7 +137,7 @@ private static object CompileAndLoad(JObject @params)
 
                 // Emit to file
                 EmitResult emitResult;
-                using (var stream = new FileStream(dllPath, FileMode.Create))
+                using (var stream = new FileStream(dllPath, FileMode.Create, FileAccess.Write, FileShare.None))
                 {
                     emitResult = compilation.Emit(stream);
                 }
@@ -227,7 +243,7 @@ private static object CompileAndLoad(JObject @params)
             }
 #endif
         }
-        
+
         private static object ListLoadedAssemblies()
         {
             var assemblies = LoadedAssemblies.Values.Select(info => new
@@ -238,14 +254,21 @@ private static object ListLoadedAssemblies()
                 type_count = info.TypeNames.Count,
                 types = info.TypeNames
             }).ToList();
-            
+
             return Response.Success($"Found {assemblies.Count} loaded dynamic assemblies", new
             {
                 count = assemblies.Count,
                 assemblies = assemblies
             });
         }
 
+        private static string SanitizeAssemblyFileName(string assemblyName)
+        {
+            var invalidChars = Path.GetInvalidFileNameChars();
+            var sanitized = new string(assemblyName.Where(c => !invalidChars.Contains(c)).ToArray());
+            return string.IsNullOrWhiteSpace(sanitized) ? $"DynamicAssembly_{DateTime.Now.Ticks}" : sanitized;
+        }
+
         private static object GetAssemblyTypes(JObject @params)
         {
             string assemblyName = @params["assembly_name"]?.ToString();

CustomTools/RoslynRuntimeCompilation/RoslynRuntimeCompiler.cs

@@ -93,7 +93,6 @@ public class CompilationHistoryEntry
 
     // Static shared history
     private static System.Collections.Generic.List<CompilationHistoryEntry> _sharedHistory = new System.Collections.Generic.List<CompilationHistoryEntry>();
-    private static int _maxHistoryEntries = 50;
 
     public System.Collections.Generic.List<CompilationHistoryEntry> CompilationHistory => _sharedHistory;
 
@@ -584,7 +583,7 @@ private void AddHistoryEntry(string sourceCode, string typeName, string methodNa
         _sharedHistory.Add(entry);
 
         // Trim if exceeded max
-        while (_sharedHistory.Count > _maxHistoryEntries)
+        while (_sharedHistory.Count > maxHistoryEntries)
         {
             _sharedHistory.RemoveAt(0);
         }
@@ -1167,7 +1166,7 @@ void DrawHistoryTab()
                 if (helperInScene.SaveHistoryEntryAsScript(selectedHistoryIndex, out string path, out string error))
                 {
                     EditorUtility.DisplayDialog("Success", $"Script saved to:\n{path}", "OK");
-                    System.Diagnostics.Process.Start("explorer.exe", $"/select,\"{path.Replace("/", "\\")}\"");
+                    EditorUtility.RevealInFinder(path);
                 }
                 else
                 {

CustomTools/RoslynRuntimeCompilation/runtime_compilation_tool.py

@@ -83,8 +83,7 @@ async def compile_runtime_code(
     }
     ```
     """
-    #await safe_info(ctx, f"Compiling runtime code for assembly: {assembly_name or 'auto-generated'}")
-    await ctx.info(f"Compiling runtime code for assembly: {assembly_name or 'auto-generated'}")
+    await safe_info(ctx, f"Compiling runtime code for assembly: {assembly_name or 'auto-generated'}")
 
     params = {
         "action": "compile_and_load",
@@ -113,8 +112,7 @@ async def list_loaded_assemblies(
     - Load timestamps
     - DLL file paths
     """
-    #await safe_info(ctx, "Retrieving loaded dynamic assemblies...")
-    await ctx.info("Retrieving loaded dynamic assemblies...")
+    await safe_info(ctx, "Retrieving loaded dynamic assemblies...")
 
     params = {"action": "list_loaded"}
     return handle_unity_command("runtime_compilation", params)
@@ -135,8 +133,7 @@ async def get_assembly_types(
     - Finding MonoBehaviour classes to attach
     - Debugging compilation results
     """
-    #await safe_info(ctx, f"Getting types from assembly: {assembly_name}")
-    await ctx.info(f"Getting types from assembly: {assembly_name}")
+    await safe_info(ctx, f"Getting types from assembly: {assembly_name}")
 
     params = {"action": "get_types", "assembly_name": assembly_name}
     return handle_unity_command("runtime_compilation", params)
@@ -187,8 +184,7 @@ async def execute_with_roslyn(
     }
     ```
     """
-    #await safe_info(ctx, f"Executing code with RoslynRuntimeCompiler: {class_name}.{method_name}")
-    await ctx.info(f"Executing code with RoslynRuntimeCompiler: {class_name}.{method_name}")
+    await safe_info(ctx, f"Executing code with RoslynRuntimeCompiler: {class_name}.{method_name}")
 
     params = {
         "action": "execute_with_roslyn",
@@ -226,8 +222,7 @@ async def get_compilation_history(
     - Tracking execution flow
     - Auditing dynamic code changes
     """
-    #await safe_info(ctx, "Retrieving compilation history...")
-    await ctx.info("Retrieving compilation history...")
+    await safe_info(ctx, "Retrieving compilation history...")
 
     params = {"action": "get_history"}
     return handle_unity_command("runtime_compilation", params)
@@ -250,8 +245,7 @@ async def save_compilation_history(
     - Share compilation sessions with team members
     - Archive successful code patterns
     """
-    #await safe_info(ctx, "Saving compilation history to file...")
-    await ctx.info("Saving compilation history to file...")
+    await safe_info(ctx, "Saving compilation history to file...")
 
     params = {"action": "save_history"}
     return handle_unity_command("runtime_compilation", params)
@@ -269,8 +263,7 @@ async def clear_compilation_history(
     This removes all tracked compilations from memory but does not delete
     saved history files. Use this to start fresh or reduce memory usage.
     """
-    #await safe_info(ctx, "Clearing compilation history...")
-    await ctx.info("Clearing compilation history...")
+    await safe_info(ctx, "Clearing compilation history...")
 
     params = {"action": "clear_history"}
     return handle_unity_command("runtime_compilation", params)