Skip to content

Support to set the custom facebook version - #745

Merged
cookpete merged 3 commits into
cookpete:masterfrom
HsuTing:support-custom-version
Nov 20, 2019
Merged

Support to set the custom facebook version#745
cookpete merged 3 commits into
cookpete:masterfrom
HsuTing:support-custom-version

Conversation

@HsuTing

@HsuTing HsuTing commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

The new version of the facebook version is v3.3. I would like to have a new config to set the facebook version. In my website, react-player will overwrite my facebook version. As a result, I can not use facebook login in my website.

Comment thread src/props.js Outdated
@HsuTing

HsuTing commented Nov 19, 2019

Copy link
Copy Markdown
Contributor Author

Hi @cookpete . Does this pr have any problem?
I hope this pr can be merged and released ASAP.

@cookpete
cookpete merged commit b7b2b1c into cookpete:master Nov 20, 2019
@cookpete

Copy link
Copy Markdown
Owner

Published in react-player@1.14.2. Thanks @HsuTing !

@HsuTing
HsuTing deleted the support-custom-version branch November 21, 2019 00:52
@HsuTing

HsuTing commented Nov 21, 2019

Copy link
Copy Markdown
Contributor Author

Thank you! 👍

@salemwosabi salemwosabi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load plans not working

@HsuTing

HsuTing commented Dec 19, 2019

Copy link
Copy Markdown
Contributor Author

load plans not working

Can you give me the example or a reproduced repo ?
Maybe I can help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants