Loop bug fix - #662
Closed
matiasmariani wants to merge 1 commit into
Closed
Conversation
Seems the loop logic was firing before the player was ready. Wrapping line 68 with an an `if (onReady){...}` statement fixes the issue.
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
Fixes cookpete/react-player#530 properly Fixes cookpete/react-player#639 Closes cookpete/react-player#662
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
Fixes cookpete/react-player#530 properly Fixes cookpete/react-player#639 Closes cookpete/react-player#662
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
Fixes cookpete/react-player#530 properly Fixes cookpete/react-player#639 Closes cookpete/react-player#662
philip-luther
added a commit
to philip-luther/react-player
that referenced
this pull request
Nov 22, 2024
Fixes cookpete/react-player#530 properly Fixes cookpete/react-player#639 Closes cookpete/react-player#662
startechguru
added a commit
to startechguru/react-codetutor
that referenced
this pull request
Mar 15, 2026
Fixes cookpete/react-player#530 properly Fixes cookpete/react-player#639 Closes cookpete/react-player#662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems the loop logic was firing before the player was ready. Wrapping line 68 with an an
if (onReady){...}statement fixes the issue.