Soundcloud - fix autoplay delegation - #614
Merged
cookpete merged 2 commits intoApr 10, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Soundcloud Player is loaded via an iframe, there are instances when that player will not be allowed to play in Chrome, even after a user has interacted with the parent document. The parent receives the autoplay permission but it's never delegated to the iframe because it currently does not have a "feature policy" attribute.
More information here: https://developers.google.com/web/updates/2017/09/autoplay-policy-changes#iframe
This PR adds that attribute for autoplay and updates the accompanying test.