Use new Vimeo player.js API - #142
Conversation
|
Hmmm.. tests are passing for me locally (they're run in Firefox and Chromium). Looking into why travis is failing. |
Updating from Froogaloop to vimeo's new [player.js API](https://github.com/vimeo/player.js#vimeo-player-api----) solved this issue. The changes are here: ccnmtl/react-player@9f1eaff Pull request to react-player is here: cookpete/react-player#142 In order to actually use vimeo in the sequence tool, you need to remove 'vimeo' from the filters in collectionwidget.js in Mediathread.
Updating from Froogaloop to vimeo's new [player.js API](https://github.com/vimeo/player.js#vimeo-player-api----) solved this issue. The changes are here: ccnmtl/react-player@9f1eaff Pull request to react-player is here: cookpete/react-player#142 In order to actually use vimeo in the sequence tool, you need to remove 'vimeo' from the filters in collectionwidget.js in Mediathread.
|
Nice work @nikolas. My only issue is that I don't like the idea of directly Is there anything different you have done compared to my attempt that I should keep in mind? What I'll probably end up doing is combining the wisdom of both before merging it in. |
|
Ah okay - good point with importing the vimeo package. I was wondering why you didn't do that with your branch and have the loadSDK stuff, but now I get it. |
|
Yeah I wanted to avoid a massive |
9f1eaff to
ef0a80b
Compare
ef0a80b to
77f8c5b
Compare
react-player now supports the new Vimeo API, so we no longer need to use our custom branch of this library. cookpete/react-player@f262c1e cookpete/react-player#142
2 participants
These changes turn out to solve my big problem I'm having with issue #140.
Also addresses issue #90.
I'm sure there are things that are missing from here. I realize you have your own vimeo branch going - I'm putting this up here for reference, to share thoughts, etc., and because it solves my problem.