Skip to content

Stack overflow when using custom playIcon #740

Description

@madeleineostoja

Current Behavior

When using a custom play icon with the new playIcon prop, clicking the icon throws an stack overflow error with recursive calls to isEqual(object) here https://github.com/CookPete/react-player/blob/master/src/utils.js#L165 in latest Chrome.

Expected Behavior

Clicking the custom play icon should have the same behavior as the default play icon, and not blow up my app

Steps to Reproduce

  1. Provide custom play icon
  2. Click it

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions