Skip to content

Vimeo video with password doesn't have duration or get progress events #514

Description

@grant-davidson

When a password protected Vimeo video is opened, the password entry field is displayed as expected.

However, after the password is entered and the video shows and is then played, the video duration isn't set.

This means that progress events aren't dispatched by react-player.

There are at least 2 fixes that could be applied:

  1. Change the progress function in Player.js to send progress events even if duration is zero (progress.playSeconds & progress.loadedSeconds would still contain useful information).
  2. If duration is not set when "play" and "seekTo" in Vimeo are called, call player.getDuration to set the duration before calling onPlay or setCurrentTime.

Would a pull request with one of these fixes be the way forward?

Fix 2 above seems more complete as duration as well as progress events is now available.

Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions