Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cookpete/react-player
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.1
Choose a base ref
...
head repository: cookpete/react-player
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.7.2
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Jun 1, 2016

  1. Add failing onDuration test 

    To duplicate the issue outlined in #52
    @cookpete
    cookpete committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    564243e View commit details
    Browse the repository at this point in the history

  2. Fix onDuration being called with null 

    Some players need onDuration to be called onReady (FilePlayer) and some need it onPlay (YouTube)
Instead of spreading onDuration amongst individual player files, here we just delay onDuration until onPlay if it returns null when onReady fires
Fixes #52
    @cookpete
    cookpete committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    fea78c0 View commit details
    Browse the repository at this point in the history

  3. Rename seekOnReady to seekOnPlay 

    It happens during onPlay, after all
    @cookpete
    cookpete committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    91f7344 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2016

  1. Add m4v and m4a extensions to filePlayer 

    Fixes #72
    @cookpete
    cookpete committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    3718730 View commit details
    Browse the repository at this point in the history

  2. Nest media switching test in a describe block 

    I don't know why this fixes the tests but it does..
    @cookpete
    cookpete committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    2fe8806 View commit details
    Browse the repository at this point in the history

  3. 0.7.2

    @cookpete
    cookpete committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    905df9e View commit details
    Browse the repository at this point in the history
Loading