Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cookpete/react-player
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.7
Choose a base ref
...
head repository: cookpete/react-player
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Choose a head ref
  • 14 commits
  • 29 files changed
  • 1 contributor

Commits on Jan 5, 2016

  1. Assume FilePlayer is ready on mount 

    Firefox doesn't reliably fire `oncanplay` after setting src, so just run onReady after mounting instead
    @cookpete
    cookpete committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    8e1c1a1 View commit details
    Browse the repository at this point in the history

  2. Remove SoundCloud stateChange binding when stopping

    @cookpete
    cookpete committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    cd96a8e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2016

  1. Add preload attribute to enable oncanplay for Firefox 

    Reverts commit 8e1c1a1
Assuming onReady caused more problems than it solved, namely onReady not firing after subsequent loads
    @cookpete
    cookpete committed Jan 6, 2016
    Configuration menu
    Copy the full SHA
    0e58f5a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2016

  1. Fix FilePlayer events 

    Binding the events directly on mount was firing the onPause/onEnded/etc events from when the component was mounted, and not the current events being passed through
    @cookpete
    cookpete committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    d3d460d View commit details
    Browse the repository at this point in the history

  2. Update travis badge to use master

    @cookpete
    cookpete committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    b0a9e3d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2016

  1. Rebase on react-transform-boilerplate 

    Uses https://github.com/CookPete/react-transform-boilerplate
Closes #8
    @cookpete
    cookpete committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    93a11dc View commit details
    Browse the repository at this point in the history

  2. Add basic karma testing 

    Closes #22
    @cookpete
    cookpete committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    8099f8f View commit details
    Browse the repository at this point in the history

  3. Use a partial shrinkwrap to limit babel packages to 6.3 

    To circumvent the slightly lame new requirement in 6.4 for semicolons after class properties
    @cookpete
    cookpete committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    e9bcd72 View commit details
    Browse the repository at this point in the history

  4. Add className prop

    @cookpete
    cookpete committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    ce021f9 View commit details
    Browse the repository at this point in the history

  5. Fix FilePlayer width and height 

    Setting width and height from props made no sense, so use 100% to fill the container element and remain consistent with other players
    @cookpete
    cookpete committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    97eb231 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2016

  1. Merge pull request #25 from CookPete/transform-boilerplate 

    Use react-transform development setup
    @cookpete
    cookpete committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    4800724 View commit details
    Browse the repository at this point in the history

  2. Separate demo files

    @cookpete
    cookpete committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    c7230e7 View commit details
    Browse the repository at this point in the history

  3. Add styles and various fixes to the demo app

    @cookpete
    cookpete committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    0b16606 View commit details
    Browse the repository at this point in the history

  4. 0.4.0

    @cookpete
    cookpete committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    b255881 View commit details
    Browse the repository at this point in the history
Loading