Drag/drop in data browser or display editor results in dead mouse on Linux

[kasemir]

There is a strange side effect of drag & drop on Linux.

1. Create a new display or open existing display in editor.

2. Drag & drop something by either dragging a new “label” from the widget palette into the editor pane, or by moving existing widgets around in the tree view. As a result, the editor will be “dirty”.

3. Try to close the dirty editor. As expected, a dialog appears: “..has been modified. Save before closing?”.
   But the No/Yes/Cancel buttons in the dialog do not react to mouse clicks, at least not on RHEL 9.4.
   When running RHEL 8.7 via a Thinlinc remove desktop, nothing in the desktop reacts to the mouse.
   It is possible to use cursor keys, escape/spare/enter to interact with the dialog, but the mouse is mostly dead.

There is no problem when using drag&drop, then saving via File/Save or Ctrl-S.
There’s also no problem when dragging a PV into the data browser. The “Add PV” dialog triggered by the PV drop functions fine.

The problem appears only when using drag&drop in the display editor, then trying to close the dirty editor right away, on Linux.
Tried JFX 20.0.2+3, 21.0.3+2, 22.0.2 and 24-ea+5, same problem.
With 20.0.2, both -Djdk.gtk.version=2 and 3 exhibit the same problem.

No problem on Mac OS, don't know about Windows.

[shroffk]

can't reproduce this on windows (using the master branch with javafx 21)

[kasemir]

Thanks for checking! Do you see this on your Linux systems?

[shroffk]

Yes, I can reproduce this.
I tried on the new training VM and was not able to reproduce it... but I was able to reproduce it on my testbed workstations.
As you mention this is only related to drag and drop.

There is just one warning I observe

(java:2686605): Gdk-WARNING **: 12:06:21.633: XSetErrorHandler() called with a GDK error trap pushed. Don't do that.

[shroffk]

The problem appears only when using drag&drop in the display editor, then trying to close the dirty editor right away

I see this only when dragging and dropping initiated from the widget panel.

When I drag and drop a PV name from another application it works fine... in the above case, once you have dragged and dropped a widget if you then proceed to do another drag and drop ( a pv from a pv table) then the problem resolves itself

[kasemir]

Since this only happens on Linux, I'm not sure if there's an issue in the Linux version of JavaFX, or if there's an error in the usage of the D&D API in the display editor, something that's generally wrong, but out of pure luck it doesn't matter on Mac and Windows.

[kasemir]

I see this only when dragging and dropping initiated from the widget panel.

Do you see it when re-ordering widgets in the widget tree view of the editor?
Or really only in the drag from the widget palette?

[shroffk]

I can reproduce it when moving widgets.
It also matters if I maintain selection, if in the above example...

If I drag and drop a widget or move it in the widget tree and then loose the selection then the problem does not happen for me

[kasemir]

then loose the selection then the problem does not happen

Indeed! Not sure what that means...

[kasemir]

I’ve tried various things to no avail.

Disabled D&D from the palette and the drag response in the editor pane, so only the widget tree does any D&D, in case there’s some conflict between them. Simplified D&D from the widget tree to drag a simple” TEST" string, no custom drag data, no drag image.
Turns out that simply starting a drag (mouse down, move by a pixel, release) triggers the problem.

Your observation regarding the selection is very interesting. After the drag, manually clearing or changing the selection indeed avoids the problem. But when I automatically clear the selection in the “okToClose” handler just before the "..Save before closing?” dialog, the problem persists. .. unless I wait 100ms after clearing the selection, then perform the rest of the okToClose code.

I’m starting to think this is internal to JFX on Linux. Since it’s fine on Windows, Mac, and even with some Linux setups, there may not be any error in the display editor code.

It’s also no show stopper because we have workarounds: De-select widgets, File/Save/CTRL-S to clear the ‘dirty’ state, or use keyboard for dialog buttons in the "..Save before closing?” dialog.

I happened to run into this error because I had to move some widget to the "front" in several displays, so I opened in editor, moved widget in tree view, close ... and was stuck, not being able to press "OK" on the save prompt. But that’s a special scenario, not how you typically use the editor. Besides, relying on the "Save before closing?" dialog to save your changes is like relying on the safety switch in the microwave when you simply open its door without pressing "Stop". Bad idea, https://xkcd.com/2886/, https://arxiv.org/abs/1504.02165

[georgweiss]

Not sure if related or same issue:
Drag-n-drop of "PV" from OPI to Data Browser displays same issue. 100% reproducible on Ubuntu/XFCE it seems. Dialog in Data Browser launches, but mouse interaction is not pssible.

[kasemir]

Good catch! Yes, I think that's the same issue. The dialog still allows keyboard interaction, but no mouse, right?

For the "Save before closing?" dialog I can hack around it by clearing the selection as Kunal had determined and waiting a little, shown below. But again that's a hack and not sure what one would do for the databrowser's add-PV dialog.

Still, this suggests there's something happening when starting the drag on Linux.
Doesn't matter if there's an actual drop.
The dialog might be triggered by the drop as in this new data browser example, but just starting a drag in an already dirty editor, moving by a pixel and aborting, then closing the editor, will result in the mouse-deaf "Save before closing?" dialog.

diff --git a/app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java b/app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java
index 1d2b607c4..2a82f88ff 100644
--- a/app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java
+++ b/app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java
@@ -16,7 +16,11 @@ import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
+import java.util.concurrent.FutureTask;
 
 import org.csstudio.display.builder.editor.DisplayEditor;
 import org.csstudio.display.builder.editor.EditorGUI;
@@ -105,7 +109,31 @@ public class DisplayEditorInstance implements AppInstance
 
         extendToolbar();
 
-        dock_item = new DockItemWithInput(this, editor_gui.getParentNode(), null, FilenameSupport.file_extensions, this::doSave);
+        dock_item = new DockItemWithInput(this, editor_gui.getParentNode(), null, FilenameSupport.file_extensions, this::doSave)
+               {
+               @Override
+               public Future<Boolean> okToClose()
+               {
+                       FutureTask<Boolean> clear_selection = new FutureTask<>(() ->
+                       {
+                       System.out.println("OK TO CLOSE?>>>");
+                       editor_gui.getDisplayEditor().getWidgetSelectionHandler().clear();   
+                       return Boolean.TRUE;
+                       });
+                       Platform.runLater(clear_selection);
+                       
+                       try
+                       {
+                                       clear_selection.get();
+                               }
+                       catch (Exception ex)
+                       {
+                               // Ignore
+                               }
+                       
+                       return super.okToClose();
+               }
+               };
         dock_pane.addTab(dock_item);
 
         // Update tab's title when model has been loaded
@@ -474,22 +502,6 @@ public class DisplayEditorInstance implements AppInstance
         }
     }
 
-    private Future<Boolean> okToClose()
-    {
-        if (save_job != null)
-        {
-            final Alert prompt = new Alert(AlertType.CONFIRMATION);
-            prompt.setTitle(Messages.FileChangedHdr);
-            prompt.setResizable(true);
-            prompt.setHeaderText(Messages.AbortSave);
-            DialogHelper.positionDialog(prompt, dock_item.getTabPane(), -200, -200);
-            if (prompt.showAndWait().orElse(ButtonType.CANCEL) != ButtonType.OK)
-                return CompletableFuture.completedFuture(false);
-        }
-
-        return CompletableFuture.completedFuture(true);
-    }
-
     private void dispose()
     {
         dock_item.setInput(null);

[georgweiss]

Yes, the solution is to confirm dialog using keyboard.

[kasemir]

Drag-n-drop of "PV" from OPI to Data Browser displays same issue.

Also happens with dragging a PV from the data browser's archive search panel into the data browser plot.