Skip to content

fix(evidence): expose standard evidence error contract - #157

Open
seonghobae wants to merge 5 commits into
mainfrom
fix/evidence-error-contract
Open

fix(evidence): expose standard evidence error contract#157
seonghobae wants to merge 5 commits into
mainfrom
fix/evidence-error-contract

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Buyer/reliability gap

originweave-evidence::EvidenceError is a public validation failure type used by network and provenance evidence construction, but protected main does not implement Rust Display / std::error::Error for it. Callers therefore cannot render or chain this stable typed failure through ordinary Rust error boundaries without special-case matching.

Test-first evidence

  • Test-only head 70b900d337be10ee6fa5b2fbbca2c4b9a65b0142 first failed only at cargo fmt --check, so that run was not accepted as RED.
  • Formatting-only head b951f6863a4abc1308ebada86299f8a0a341def8 reached the intended compile boundary: the new integration test could not call to_string() or Error::source() because EvidenceError lacked Display and std::error::Error. This is the valid RED.
  • Production head f151c24ec4bd6206891236f574d9c1063d9594d0 added only deterministic credential-safe Display text for the five existing variants plus impl std::error::Error for EvidenceError {}.

The regression also requires Error::source() to remain empty for every current variant.

Protected-main reconciliation

Protected main is exact 0841d2ab3d8b5e60a03c0a8e818cf438e2716829. Current exact contributor head is eac07a7125e541c4912b195a7522c319cb2b8792. It is a non-destructive two-parent reconciliation that preserves current protected-main source and overlays only this PR's evidence-error contract plus its focused regression and one code-current changelog edit. The semantic diff remains exactly three files.

No predecessor-head checks or reviews transfer to this moved head.

Exact-current verification

On unchanged exact head eac07a7125e541c4912b195a7522c319cb2b8792:

  • CI run 31978497609: success, including Rust contracts and exact owned-production function/line/region/branch coverage;
  • SAST Semgrep run 31978497547: success;
  • Security Scan run 31978497543: success;
  • no inline review threads are currently returned.

The earlier unassigned-runner scanner state was routed with exact identities to existing organization control-plane issue ContextualWisdomLab/.github#712. Both scanner runs subsequently completed successfully without leaf branch churn, so that queue state is retained only as historical transient evidence rather than a source defect or current blocker.

No predecessor-head, queued, skipped, cancelled, absent, stale, status-only, model-only, or synthetic evidence is promoted to current proof.

Scope boundary

This lane changes no evidence validation rule, redaction behavior, network capture, provenance data, persistence, retention, policy, workflow, or secret handling. The production remedy is limited to the standard Rust error contract for the existing five public variants.

Live repository governance and every applicable exact-current-head workflow remain authoritative. A qualifying independent current-head/latest-push approval is still required by the live organization ruleset. Protected-main AGENTS.md independently forbids this scheduled actor from merging, self-approving, altering workflows, adding secrets, weakening checks, tagging, or publishing.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 43c203a5-87ec-4c60-8dbb-756301d92400

📥 Commits

Reviewing files that changed from the base of the PR and between 0841d2a and eac07a7.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • crates/originweave-evidence/src/lib.rs
  • crates/originweave-evidence/tests/error_contract.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant