Skip to content

[CI-4518] Expose is_slotted in Search/Browse API Responses #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2025
Merged

[CI-4518] Expose is_slotted in Search/Browse API Responses #159

merged 3 commits into from
Jun 12, 2025

Conversation

@Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Jun 12, 2025

  • Adds new field isSlotted to Result class that is serialized from is_slotted from the API responses.
  • Also fixes some tests that were breaking due to our test catalog changing

Note: There are a couple of breaking tests in the ConstructorIOTasksTest.java. This is unrelated to this PR and is due to how we're picking the timeframe to test. Will fix in a separate PR

@Mudaafi Mudaafi requested a review from a team June 12, 2025 06:36
esezen
esezen approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mudaafi Mudaafi merged commit 97c29cd into master Jun 12, 2025
3 of 4 checks passed
@Mudaafi Mudaafi deleted the ci-4518-java-expose-is_slotted-as-a-field-in-api-responses branch June 12, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esezen esezen esezen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mudaafi @esezen