Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for angularjs #50

Closed
wants to merge 1 commit into from

Conversation

Masadow
Copy link
Contributor

@Masadow Masadow commented Aug 7, 2015

Same thing as loaders.css.js but for angular users that don't want to rely on JQuery or whatever js framework.

This code relies on angular directives to achieve the same result and changes to the loader class will be instantly reflected (provided that you're in a scope digest)

@Masadow Masadow mentioned this pull request Aug 7, 2015
@ConnorAtherton
Copy link
Owner

Sorry for the late reply, I haven't been keeping up to date with OS stuff for the past 2 months. Thanks for the pr, I'm not going to merge this because I don't want the scope to creep away from the css. I was reluctant to accept the initial jQuery helper. But thank you so much for taking the time to contribute. I'm updating the README now to link to this pr in case some people need it.

@Masadow
Copy link
Contributor Author

Masadow commented Oct 28, 2015

Thanks, no worries :)

Jimmy Delas
Twitter https://twitter.com/masadowbdx
Linkedin http://www.linkedin.com/profile/view?id=154981683
GitHub https://github.com/Masadow

On Wed, Oct 28, 2015 at 6:03 AM, Connor Atherton notifications@github.com
wrote:

Sorry for the late reply, I haven't been keeping up to date with OS stuff
for the past 2 months. Thanks for the pr, I'm not going to merge this
because I don't want the scope to creep away from the css. I was reluctant
to accept the initial jQuery helper. But thank you so much for taking the
time to contribute. I'm updating the README now to link to this pr in case
some people need it.


Reply to this email directly or view it on GitHub
#50 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants