Skip to content

Commit 5b289d7

Browse files
authored
fix: mark permanently_closed as deprecated (googlemaps#365)
1 parent 865cf78 commit 5b289d7

1 file changed

Lines changed: 22 additions & 1 deletion

File tree

googlemaps/places.py

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,13 @@
100100
^ PLACES_DETAIL_FIELDS_ATMOSPHERE
101101
)
102102

103+
DEPRECATED_FIELDS = {"permanently_closed"}
104+
DEPRECATED_FIELDS_MESSAGE = (
105+
"Fields, %s, are deprecated. "
106+
"Read more at https://developers.google.com/maps/deprecations."
107+
)
108+
109+
103110
def find_place(
104111
client, input, input_type, fields=None, location_bias=None, language=None
105112
):
@@ -143,7 +150,14 @@ def find_place(
143150
"the given value is invalid: '%s'" % input_type
144151
)
145152

146-
if fields:
153+
if fields:
154+
deprecated_fields = set(fields) & DEPRECATED_FIELDS
155+
if deprecated_fields:
156+
warnings.warn(
157+
DEPRECATED_FIELDS_MESSAGE % str(list(deprecated_fields)),
158+
DeprecationWarning,
159+
)
160+
147161
invalid_fields = set(fields) - PLACES_FIND_FIELDS
148162
if invalid_fields:
149163
raise ValueError(
@@ -422,6 +436,13 @@ def place(client, place_id, session_token=None, fields=None, language=None):
422436
params = {"placeid": place_id}
423437

424438
if fields:
439+
deprecated_fields = set(fields) & DEPRECATED_FIELDS
440+
if deprecated_fields:
441+
warnings.warn(
442+
DEPRECATED_FIELDS_MESSAGE % str(list(deprecated_fields)),
443+
DeprecationWarning,
444+
)
445+
425446
invalid_fields = set(fields) - PLACES_DETAIL_FIELDS
426447
if invalid_fields:
427448
raise ValueError(

0 commit comments

Comments
 (0)