Confluence: remove extra try catch

Author: gonchik

atlassian/compass/__init__.py

@@ -61,9 +61,7 @@ def upload_package_dependencies_lock_file(
 
     def delete_package_dependencies(self, component_id, source_id):
         """Delete package dependencies for a component and source."""
-        path = self.url_joiner(
-            self.api_root, f"compass/v1/package_dependencies/lock_file/{component_id}/{source_id}"
-        )
+        path = self.url_joiner(self.api_root, f"compass/v1/package_dependencies/lock_file/{component_id}/{source_id}")
         return self.delete(path)
 
     def get_forge_app_attachment(self, component_id, forge_app_id, key, not_json_response=True):

atlassian/confluence/cloud/cloud.py

@@ -157,11 +157,7 @@ def get_page_by_id(
         if expand:
             params["expand"] = ",".join(expand)
 
-        try:
-            return self.get(endpoint, params=params)
-        except Exception as e:
-            log.error(f"Failed to retrieve page with ID {page_id}: {e}")
-            raise
+        return self.get(endpoint, params=params)
 
     def get_pages(
         self,
@@ -444,11 +440,7 @@ def create_page(
         if parent_id:
             data["parentId"] = parent_id
 
-        try:
-            return self.post(endpoint, data=data)
-        except Exception as e:
-            log.error(f"Failed to create page: {e}")
-            raise
+        return self.post(endpoint, data=data)
 
     def update_page(
         self,
@@ -503,12 +495,8 @@ def update_page(
 
         # First, get the current page to get its version
         if version is None:
-            try:
-                current_page = self.get_page_by_id(page_id, get_body=False)
-                version = current_page.get("version", {}).get("number", 1)
-            except Exception as e:
-                log.error(f"Failed to retrieve page for update: {e}")
-                raise
+            current_page = self.get_page_by_id(page_id, get_body=False)
+            version = current_page.get("version", {}).get("number", 1)
 
         # Prepare update data
         data = {
@@ -528,11 +516,7 @@ def update_page(
             if representation:
                 data["body"][body_format]["representation"] = representation
 
-        try:
-            return self.put(endpoint, data=data)
-        except Exception as e:
-            log.error(f"Failed to update page: {e}")
-            raise
+        return self.put(endpoint, data=data)
 
     def delete_page(self, page_id: str) -> bool:
         """

tests/confluence/test_confluence_cloud.py

@@ -4,9 +4,11 @@
 """
 
 import pytest
+import logging
 from unittest.mock import patch
 
 from atlassian.confluence import ConfluenceCloud
+from atlassian.confluence.cloud.cloud import ConfluenceCloud as ConfluenceCloudV2
 from atlassian.errors import ApiError
 
 
@@ -26,6 +28,20 @@ def test_init_defaults(self):
         assert confluence.api_root == "wiki/api/v2"
         assert confluence.cloud is True
 
+    @patch.object(ConfluenceCloudV2, "get_page_by_id")
+    @patch.object(ConfluenceCloudV2, "put")
+    def test_update_page_does_not_log_and_swallow_api_errors(self, mock_put, mock_get_page, caplog):
+        confluence_cloud = ConfluenceCloudV2("https://test.atlassian.net", token="test-token")
+        mock_get_page.return_value = {"version": {"number": 3}}
+        error = RuntimeError("update failed")
+        mock_put.side_effect = error
+
+        with caplog.at_level(logging.ERROR, logger="atlassian.confluence.cloud.cloud"):
+            with pytest.raises(RuntimeError, match="update failed"):
+                confluence_cloud.update_page("123", title="Updated")
+
+        assert not caplog.records
+
     def test_init_custom_values(self):
         """Test ConfluenceCloud client initialization with custom values."""
         confluence = ConfluenceCloud(