Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are not applied for CreditNote type #164

Closed
jarekglapski opened this issue Aug 1, 2019 · 1 comment
Closed

Some tests are not applied for CreditNote type #164

jarekglapski opened this issue Aug 1, 2019 · 1 comment
Milestone

Comments

@jarekglapski
Copy link

Some tests, like:
[UBL-SR-05]-Payment terms shall occur maximum once
and many more are not applied for CreditNote type, because the corresponding template matches only an Invoice:
<xsl:template match="/ubl:Invoice" mode="M11" priority="1006">

According to specs, at least some of them (ex: [UBL-SR-05]) should apply to CreditNotes as well.
I believe, all of them are "warnings", but perhaps it is worth to be refactored anyway.

@oriol
Copy link
Collaborator

oriol commented Sep 20, 2019

The context has been changed to value="/ubl:Invoice | /cn:CreditNote" so this is resolved.

@oriol oriol closed this as completed Sep 20, 2019
@oriol oriol added this to the v1.3.0 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants