Added back-end unit tests for all controllers, services and more + fixes #603
+22,809
−2,854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes in this commit remove a lot of existing code, we should take a look at these changes and consider alternatives
Start fixing unit tests that end with a failure or error
to do: make sure the test coverage is still ok
WilcoLouwerse
changed the title
WilcoLouwerse
requested review from
bbrands02,
rjzondervan and
rubenvdlinde
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
🔍 Code Quality Check Results✅ Basic quality checks passed!
Available Commandscomposer check # Basic quality checks
composer check:strict # Full quality checks
composer fix # Auto-fix code style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://conduction.atlassian.net/browse/REGISTERS-221
docker exec master-nextcloud-1 bash -c "cd /var/www/html && phpunit --bootstrap tests/bootstrap.php apps-extra/openregister/tests"