Repository navigation
fix(notifications): send every group notification to a group an install has, and that can read the object - #1200
Merged
rubenvdlinde merged 2 commits intoSep 28, 2026
Conversation
…ll has, and that can read the object Twenty rules named role words (coordinator, mentor, examboard, exam-board, study-advisor, compliance-officer) that no install provisions, so they reached nobody. Each now names declared oauth2 scope groups that read the object, and NotificationRecipientGroupsAreDeclaredTest fails on any group outside that set. See openspec/changes/notification-recipients-provisioned/.
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-28 16:59 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Twenty notification rules sent to groups named by role words (
coordinator,mentor,examboard,exam-board,study-advisor,compliance-officer) that no install provisions, so they fired and reached nobody. Each now names groups the register declares as oauth2 scopes, chosen so the group can read the object it hears about, and a new register test fails on any group recipient outside that set or outside the schema's read list.openspec/changes/notification-recipients-provisioned/proposal.md):coordinatortocoordinatorswhere coordinators read the object; the exam-board role tocompliance-officers(as D23 does for the import guards);study-advisortoteam-leads(BSA readers);compliance-officertocompliance-officers;mentordropped where no mentor field exists, with the rule reaching the staff group that reads the object (AttendanceFlagkeeps itsmentorIdfield recipient). Instructors are never added: a mentor rule sent to all instructors would reach every teacher.info.version0.30.0 to 0.30.1.x-property-rbacrole words are a different vocabulary and are left alone.AssessmentItemPoolsRegisterTest,AttendanceThresholdRegisterTest).Change:
openspec/changes/notification-recipients-provisioned/.Verification
vendor/bin/phpunit --filter NotificationRecipientGroupsAreDeclaredTestred first on development (26 undeclared group names, and groups unable to read their object), green after.vendor/bin/phpunit --no-coverage): 2114 tests OK, 5 skipped.composer check:strict(TMPDIR in the clone, timeout off): exit 0 (ALL CHECKS PASSED, full suite included).npm run lint0,npm run format0,npm run check:schema-l10n0. Notest:l10nscript.HYDRA_GATE_BASE_REF=origin/development): exit 6, all inherited and identical to development: 3 stub-scan (six untouched services), 25, 49, 55, 60, and 101 (DossierReview, ExchangePartnerApproval, TeldatumCheck without demo rows; LvsResult and OsoImportDossier nulldataExchangeJobId, LvsResult fixed in fix(lvs): freeze a verified LVS score now that LvsResult is no longer append-only #1195).openspec validate notification-recipients-provisionedvalid.Landing note
Touches
lib/Settings/learniq_register.json(info.versionand 19 schemas); #1195 (lvs-score-freeze) also bumpsinfo.version.🤖 Generated with Claude Code