Skip to content

Replace gtags with RUM #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxmeinhold merged 3 commits into from
Mar 19, 2021
Merged

Replace gtags with RUM #242

mxmeinhold merged 3 commits into from
Mar 19, 2021

Conversation

@mxmeinhold
Copy link
Collaborator

@mxmeinhold mxmeinhold commented Feb 28, 2021 •
edited
Loading

Resolves #201

TODO:

  • It appears as though groups are not being submitted as a list
  • Squash fixup commits
  • Make issues
    • Fall back to yarn for RUM when blocked by adblock
    • Check if adblock blocks submission too, if so, configure a proxy

@mxmeinhold
Copy link
Collaborator Author

mxmeinhold commented Mar 15, 2021

Alright, deployed this on dev to test it out. Do we need to anonymise anything? I figure not, since we don't protect identity of who's signed what.

adamhb123
adamhb123 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@adamhb123 adamhb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxmeinhold
Copy link
Collaborator Author

mxmeinhold commented Mar 19, 2021

Force pushing to squash fixup

@mxmeinhold mxmeinhold merged commit 070e099 into ComputerScienceHouse:develop Mar 19, 2021
@mxmeinhold mxmeinhold deleted the rum branch March 19, 2021 22:33
@mxmeinhold mxmeinhold mentioned this pull request Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devinmatte devinmatte devinmatte approved these changes

+1 more reviewer

@adamhb123 adamhb123 adamhb123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Track usage with Datadog RUM

3 participants

@mxmeinhold @devinmatte @adamhb123