You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This reduces binary size a lot - likely at the cost of less verbose callstack in crashes. It is worth investigating if the binary size change pays of for us and if it has further implications, maybe even in performance.
For an implementation, make it controllable via a CMake option (which is default ON in Release builds) and set the target property CXX_VISIBILITY_PRESET to hidden for selected PIConGPU targets. Note that there is also "inlines hidden" causing all inlined class member functions to have hidden visibility.
The text was updated successfully, but these errors were encountered:
Other C++ template metaprogramming-heavy projects such as
pybind11
make extensive use of symbol hiding via-fvisibility=hidden
:This reduces binary size a lot - likely at the cost of less verbose callstack in crashes. It is worth investigating if the binary size change pays of for us and if it has further implications, maybe even in performance.
For an implementation, make it controllable via a CMake option (which is default
ON
inRelease
builds) and set the target propertyCXX_VISIBILITY_PRESET
tohidden
for selected PIConGPU targets. Note that there is also "inlines hidden" causing all inlined class member functions to have hidden visibility.The text was updated successfully, but these errors were encountered: