Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer onboarding notification added #755

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Mayank77maruti
Copy link

@Mayank77maruti Mayank77maruti commented Oct 22, 2024

Closes #705

Description
This PR introduces a new GitHub Action that automatically posts a comment on a pull request once it has been merged into the main branch.


Important

Adds a GitHub Action to comment on merged PRs with personalized messages based on the author's contribution count.

  • GitHub Action:
    • New workflow developer_onboarding_notification.yml to comment on merged PRs.
    • Triggers on pull_request_target event when PR is closed and merged.
  • Functionality:
    • Sets environment variables for AUTHOR, REPO, and OWNER.
    • Counts merged PRs by the author using actions/github-script@v6.
    • Posts a congratulatory comment with a random emoji and personalized message based on PR count.
  • Messages:
    • Custom messages for 1, 2, 3, 5, 10, and more than 10 merged PRs, mentioning himanshu-dixit for support.

This description was created by Ellipsis for ea29ff7. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to ea29ff7 in 32 seconds

More details
  • Looked at 116 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/developer_onboarding_notification.yml:4
  • Draft comment:
    Using 'pull_request_target' can be a security risk if not handled properly. Ensure that the action does not execute untrusted code.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. .github/workflows/developer_onboarding_notification.yml:16
  • Draft comment:
    Consider using 'actions/checkout@v3' instead of 'v4' unless there's a specific reason to use 'v4'.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The action uses 'actions/checkout@v4', but the latest stable version is 'v3'. Using the latest stable version is recommended unless there's a specific reason to use a different one.

Workflow ID: wflow_NbMwS6Hlk3rSFoiN


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

const prCount = parseInt(process.env.PR_COUNT);
const author = process.env.AUTHOR;
const mention = 'himanshu-dixit';
const prNumber = context.payload.pull_request.number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import 'context' from '@actions/github' to use 'context.payload.pull_request.number'.

@Mayank77maruti
Copy link
Author

Hey @himanshu-dixit , The pr is ready to be reviewed. please do review it.

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:21am

@Mayank77maruti
Copy link
Author

Hey @himanshu-dixit , I have participated in an opensource competition and it will be really helpful if you can merge this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement messages to celebrate successful PR contributions
1 participant