Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Gradle tweaks #119

Merged
merged 10 commits into from
Aug 11, 2024
Merged

Minor Gradle tweaks #119

merged 10 commits into from
Aug 11, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 11, 2024

Kotlin sources in idea-plugin module can't be viewed in IDEA as we removed its dependency explicitly. Now we compileOnly stdlib for all modules that applied Kotlin plugin, no need to worry small things like this.

Kotlin sources in idea-plugin module can't be viewed in IDEA as we removed its dependency explicitly. Now we `compileOnly` stdlib for all modules that applied Kotlin plugin, no need to worry small things like this.
@Goooler Goooler requested a review from egorikftp August 11, 2024 11:00
@Goooler Goooler changed the title Compile only Kotlin stdlib for all related modules Optimize Kotlin stdlib dependencies Aug 11, 2024
@Goooler Goooler changed the title Optimize Kotlin stdlib dependencies Minor Gradle tweaks Aug 11, 2024
@Goooler Goooler changed the title Minor Gradle tweaks Minor Gradle cleanups Aug 11, 2024
@Goooler
Copy link
Member Author

Goooler commented Aug 11, 2024

Will squash this PR.

Comment on lines 62 to 63
enableStrongSkippingMode = true
stabilityConfigurationFile = layout.projectDirectory.file("stability_config.conf")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we share this config and enable strong-skip for App and Plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will remove it then.

@Goooler Goooler changed the title Minor Gradle cleanups Minor Gradle tweaks Aug 11, 2024
@Goooler Goooler merged commit 8dad876 into main Aug 11, 2024
2 checks passed
@Goooler Goooler deleted the compile-only-for-all-modules branch August 11, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants