-
Notifications
You must be signed in to change notification settings - Fork 749
ci: CPLYTM-823 - introduce yamllint check for controls and profiles #13589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daa42cd
to
d4c33ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a welcome edition something I have wanted to do for a while.
However, it seems the config isn't being loaded based on my testing. Please take a look.
d4c33ed
to
8e6c242
Compare
This workflow will detect files changed by the PR and in case controls or profiles files are included in the list, it will execute yamllint using the .yamllint configuration file located in root directory. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
8e6c242
to
b1ff09e
Compare
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue. But it should be good after that.
Co-authored-by: Matthew Burket <m@tthewburket.com>
Code Climate has analyzed commit 9f21c33 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
This workflow will detect files changed by the PR and in case controls or profiles files are included in the list, it will execute
yamllint
using the.yamllint
configuration file located in.github
directory.Rationale:
Review Hints:
The initial configuration is very lenient and focusing only on controls and profiles files.
However, it can be easily extended on-demand and gradually when inconsistencies are being fixed.
Example: