Skip to content

Conversation

marcusburghardt
Copy link
Member

@marcusburghardt marcusburghardt commented Jun 17, 2025

Description:

This workflow will detect files changed by the PR and in case controls or profiles files are included in the list, it will execute yamllint using the .yamllint configuration file located in .github directory.

Rationale:

  • Many control files and profiles files are not consistent, creating avoidable noise when automated changes are executed.
  • This PR is not changing inconsistent files, and will only report files modified by the tested PR.
  • Separate PRs will be created to fix inconsistencies, while this CI test will help us to avoid introduction of new inconsistencies.

Review Hints:

The initial configuration is very lenient and focusing only on controls and profiles files.
However, it can be easily extended on-demand and gradually when inconsistencies are being fixed.

Example:

@marcusburghardt marcusburghardt added this to the 0.1.78 milestone Jun 17, 2025
@marcusburghardt marcusburghardt requested a review from Mab879 June 17, 2025 21:02
@Mab879 Mab879 self-assigned this Jun 17, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a welcome edition something I have wanted to do for a while.

However, it seems the config isn't being loaded based on my testing. Please take a look.

This workflow will detect files changed by the PR and in case controls
or profiles files are included in the list, it will execute yamllint
using the .yamllint configuration file located in root directory.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue. But it should be good after that.

Co-authored-by: Matthew Burket <m@tthewburket.com>
Copy link

Code Climate has analyzed commit 9f21c33 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt requested a review from Mab879 June 18, 2025 18:19
@Mab879 Mab879 merged commit 366cb88 into ComplianceAsCode:master Jun 18, 2025
136 of 137 checks passed
@marcusburghardt marcusburghardt deleted the yamllint_ci branch June 19, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants