VisualStudio now suggest to use [field: ...] instead of [property: ...]. Is it safe to switch?

[AndreasReitberger]

As I started to use this toolkit, I needed to use the [property: ...] to pass attributes to the SourceGenerator.
Is this still so? Visual Studio says now to switch to field, however I wasn't able to find a change in the changelog indicating this.

        // This?
        [ObservableProperty]
        [property: JsonIgnore, XmlIgnore]
        RepetierPrinterState state;
        partial void OnStateChanged(RepetierPrinterState value)
        {
            OnRepetierPrinterStateChangedEvent(new RepetierPrinterStateChangedEventArgs()
            {
                NewPrinterState = value,
                SessonId = SessionId,
                CallbackId = -1,
                Printer = GetActivePrinterSlug(),
            });
            UpdatePrinterState(value);
        }
       // Or this?
        [ObservableProperty]
        [field: JsonIgnore, XmlIgnore]
        RepetierCurrentPrintInfo activePrintInfo;
        partial void OnActivePrintInfoChanged(RepetierCurrentPrintInfo value)
        {
            OnPrintInfoChangedEvent(new RepetierActivePrintInfoChangedEventArgs()
            {
                SessonId = SessionId,
                NewActivePrintInfo = value,
                Printer = GetActivePrinterSlug(),
            });
            UpdateActivePrintInfo(value);
        }

[Sergio0694]

That is still the case, yes. If you want to pass an attribute to the generated property, property: is the correct thing to use. It seems the diagnostic suppressor isn't working as expected here. Are you able to create a minimal repro (possibly in a standalone project) that reproduces this, so we can investigate it? Also have you tried restarting your IDE just in case?

[AndreasReitberger]

Thanks for the clarification. I used the current Preview version of Visual Studio. There, I get this warning. If I open it with the stable version of Visual Studio, it seems to work.

So I guess it's not a problem of the project it self, but from the Visual Studio version.

Gives warnings

Doesn't warn

[Sergio0694]

Would you mind opening an issue about this in the Roslyn repo, just for tracking? Given that it'd seem to be a regression. Feel free to link back to this discussion, and possibly provide a minimal repro they can also use. Thank you! 🙂