Skip to content

Commit cb35444

Browse files
committed
Fix IBufferWriterExtensions Write for unmanaged types
1 parent 7b53ae2 commit cb35444

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/CommunityToolkit.HighPerformance/Extensions/IBufferWriterExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static unsafe void Write<T>(this IBufferWriter<byte> writer, T value)
4949
where T : unmanaged
5050
{
5151
int length = sizeof(T);
52-
Span<byte> span = writer.GetSpan(1);
52+
Span<byte> span = writer.GetSpan(length);
5353

5454
if (span.Length < length)
5555
{

tests/CommunityToolkit.HighPerformance.UnitTests/Extensions/Test_IBufferWriterExtensions.cs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,4 +118,20 @@ public void Test_IBufferWriterExtensions_WriteReadOverItems_ReadOnlySpan()
118118

119119
Assert.IsTrue(span.SequenceEqual(buffer.AsSpan()));
120120
}
121+
122+
[TestMethod]
123+
public unsafe void Test_IBufferWriterExtensions_WriteExceedingFreeCapacity()
124+
{
125+
ArrayPoolBufferWriter<byte> writer = new();
126+
127+
// Leave only one byte of free capacity
128+
int count = writer.Capacity - 1;
129+
for (int i = 0; i < count; i++)
130+
{
131+
writer.Write<byte>(0);
132+
}
133+
134+
// Write 4 bytes
135+
writer.Write(1);
136+
}
121137
}

0 commit comments

Comments
 (0)