Skip to content

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jan 10, 2022

Fixes

I was comparing your settings.xamlstyler with mine to see the difference and noticed a few typos (I've been using this file for about a month and copied the settings from here https://github.com/Xavalon/XamlStyler/wiki/External-Configurations).

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

I was comparing your settings.xamlstyler with mine to see the difference and noticed a few typos (I've been using this file for about a month and copied the settings from here https://github.com/Xavalon/XamlStyler/wiki/External-Configurations).
@ghost
Copy link

ghost commented Jan 10, 2022

Thanks HavenDV for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker January 10, 2022 13:08
@michael-hawker michael-hawker added this to the 8.0 milestone Jan 10, 2022
@michael-hawker
Copy link
Member

Thanks @HavenDV for catching these!

@HavenDV
Copy link
Contributor Author

HavenDV commented Jan 10, 2022

I also provided a PR for all other repositories of this organization, which contains this file with the same problems:
https://github.com/CommunityToolkit/Microsoft.Toolkit.Win32/pull/339/files
https://github.com/CommunityToolkit/SceneLoader/pull/15/files
https://github.com/CommunityToolkit/Lottie-Windows/pull/481/files
https://github.com/CommunityToolkit/Graph-Controls/pull/181/files

@michael-hawker michael-hawker merged commit 32e1f80 into CommunityToolkit:main Jan 13, 2022
@HavenDV HavenDV deleted the patch-1 branch February 19, 2022 07:19
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants