Merge pull request #4125 from Nirmal4G/hotfix/warnings

Fix most build warnings from the projects

Author: michael-hawker

UITests/UITests.Tests.Shared/Controls/GridSplitterTest.cs

@@ -2,15 +2,14 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using Microsoft.Windows.Apps.Test.Foundation;
-using Microsoft.Windows.Apps.Test.Foundation.Controls;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
-using System.Linq;
-using System.Threading.Tasks;
+using System;
 using System.Collections.Generic;
 using System.Dynamic;
-using System;
+using System.Linq;
+using System.Threading.Tasks;
+
+using Microsoft.Windows.Apps.Test.Foundation;
+using Microsoft.Windows.Apps.Test.Foundation.Controls;
 
 #if USING_TAEF
 using WEX.Logging.Interop;
@@ -20,9 +19,11 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 #endif
 
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
+
 namespace UITests.Tests
 {
-
     [TestClass]
     public class GridSplitterTest : UITestBase
     {

UITests/UITests.Tests.Shared/Controls/RangeSelectorTest.cs

@@ -3,8 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Windows.Apps.Test.Foundation.Controls;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
 
 #if USING_TAEF
 using WEX.Logging.Interop;
@@ -14,9 +12,11 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 #endif
 
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
+
 namespace UITests.Tests
 {
-
     [TestClass]
     public class RangeSelectorTest : UITestBase
     {

UITests/UITests.Tests.Shared/Controls/RichSuggestBoxTest.cs

@@ -2,11 +2,11 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using Microsoft.Windows.Apps.Test.Automation;
 using Microsoft.Windows.Apps.Test.Foundation;
 using Microsoft.Windows.Apps.Test.Foundation.Controls;
 using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
 using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
-using Microsoft.Windows.Apps.Test.Automation;
 
 #if USING_TAEF
 using WEX.Logging.Interop;

UITests/UITests.Tests.Shared/UITestBase.cs

@@ -6,8 +6,6 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
-using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
 using System.Threading.Tasks;
 
 #if USING_TAEF
@@ -18,6 +16,9 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 #endif
 
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
+using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
+
 namespace UITests.Tests
 {
     public abstract class UITestBase

UnitTests/UnitTests.HighPerformance.UWP/UnitTests.HighPerformance.UWP.csproj

@@ -152,6 +152,10 @@
     <PackageReference Include="System.Runtime.CompilerServices.Unsafe">
       <Version>5.0.0</Version>
     </PackageReference>
+    <!-- For warnings ILT0010, ILT0005, ILT0003 -->
+    <PackageReference Include="System.Xml.XPath.XmlDocument">
+      <Version>4.0.1</Version>
+    </PackageReference>
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\Microsoft.Toolkit.HighPerformance\Microsoft.Toolkit.HighPerformance.csproj">

UnitTests/UnitTests.NetCore/Mvvm/Test_ObservablePropertyAttribute.cs

@@ -361,15 +361,15 @@ public enum Animal
         public partial class ModelWithValueProperty : ObservableObject
         {
             [ObservableProperty]
-            private string value;
+            private string? value;
         }
 
         public partial class ModelWithValuePropertyWithValidation : ObservableValidator
         {
             [ObservableProperty]
             [Required]
             [MinLength(5)]
-            private string value;
+            private string? value;
         }
 
         public partial class ViewModelWithValidatableGeneratedProperties : ObservableValidator

UnitTests/UnitTests.Notifications.UWP/UnitTestApp.xaml.cs

@@ -16,6 +16,9 @@ namespace UnitTests.Notifications.UWP
     /// </summary>
     public sealed partial class App : Application
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="App"/> class.
+        /// </summary>
         public App()
         {
             InitializeComponent();

UnitTests/UnitTests.Shared/.editorconfig

@@ -1,7 +1,17 @@
-[*.{cs,vb}]
 
-# SA1601: Partial elements should be documented
+# Analyzer Configurations for Unit Test sources
+
+# C# Source Files
+[*.cs]
+
+# A C# partial element is missing a documentation header.
 dotnet_diagnostic.SA1601.severity = none
+
+# The Parameter has no matching param tag in the XML comment.
 dotnet_diagnostic.CS1573.severity = none
+
+# Missing XML comment for publicly visible type or member.
 dotnet_diagnostic.CS1591.severity = none
-dotnet_diagnostic.CS1712.severity = none
+
+# The Type parameter has no matching typeparam tag in the XML comment.
+dotnet_diagnostic.CS1712.severity = none