Fixed Segment hover part CornerRadius#739
Conversation
|
Yes, the new design is the expected behavior. No underlying knowledge of the control should be required and creating a new style and controlTemplate is a not expected. Why have a property if, when you set it, someone tells you "oh, to make that work properly you have to write a style and controlTemplate" - yeah, bye bye - remove the property if it doesn't work, or keep it and make it work :) |
|
@HEIC-to-JPEG-Dev I only say you may have to write your own style, because frankly I don't love how this looks 😂. Don't really know how to improve it though... |
|
FYI @niels9001 think this is good, eh? |
Arlodotexe
left a comment
There was a problem hiding this comment.
Tested locally, fix works as expected when SegmentedItem.CornerRadius is set.
Fixes #716
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
In the default style, regardless of the

SegmentItem.CornerRadius, thePART_Hover.CornerRadiuswill be 2.What is the new behavior?
In the default style,
PART_Hover.CornerRadiuswill be the value assigned toSegmentItem.CornerRadius.PR Checklist
Please check if your PR fulfills the following requirements:
The default style behavior is minorly different. Might result in undesired visuals in rare cases.
Other information
I suppose this is better behavior for the default style. However in reality, I think the answer to #716 is that if you want to modify the
CornerRadiusof aSegmentedItemand really make it look good, you need to write your ownStyleandControlTemplate