Fixed a11y issue #391#702
Merged
Arlodotexe merged 1 commit intoCommunityToolkit:mainfrom Jul 17, 2025
Merged
Conversation
Contributor
Author
@dotnet-policy-service agree company="Microsoft" |
niels9001
reviewed
Jul 17, 2025
components/SettingsControls/src/SettingsCard/SettingsCardAutomationPeer.cs
Show resolved
Hide resolved
niels9001
approved these changes
Jul 17, 2025
Collaborator
niels9001
left a comment
There was a problem hiding this comment.
@Arlodotexe @Jaylyn-Barbee I'm not able to validate these changes as I'm OOF, but looking at the code, this does make sense to me :)!
11 tasks
Arlodotexe
approved these changes
Jul 17, 2025
Member
Arlodotexe
left a comment
There was a problem hiding this comment.
Tested locally, appears to work as intended without regressions. Thanks for helping us improve the toolkit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391
Since it is optional for the
SettingsCardto be clickable, there are times where it is expecting button like behaviors when it is not in button mode which is an accessibility issue. To fix, I ensured the card uses the default button behaviors and also override the pattern function to only expose the button bits when the card is in button mode.PR Type
What kind of change does this PR introduce?
What is the current behavior?
#391
What is the new behavior?
The
SettingsCardAutomationPeercorrectly behaves as a button when in the clickable mode.PR Checklist
Please check if your PR fulfills the following requirements:
Other information