Fire Action PopupOptions.OnTappingOutsideOfPopup when Android Back Button Pressed#2799
Merged
TheCodeTraveler merged 4 commits intomainfrom Jul 8, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android back button handling in PopupPage.OnBackButtonPressed so that tapping the back button now invokes the OnTappingOutsideOfPopup action and dismisses the popup when allowed.
- Switched the dismissal check from
GetCanBeDismissedByTappingOutsideOfPopuptotapOutsideOfPopupCommand.CanExecute(null) - Replaced the direct
CloseAsynccall withtapOutsideOfPopupCommand.Execute(null) - Ensures the popup remains open by always returning
true
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs:103
- Add unit tests to verify that
OnBackButtonPressedcorrectly fires theOnTappingOutsideOfPopupaction and dismisses the popup whenCanBeDismissedByTappingOutsideOfPopupis true, and remains inert otherwise.
protected override bool OnBackButtonPressed()
…ndroid-Back-Button-Pressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates the logic in
PopupPage.OnBackButtonPressedto fireAction PopupOptions.OnTappingOutsideOfPopupand dismiss the Popup whenCanBeDismissedByTappingOutsideOfPopupistrue.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Tp avoid duplicating code, this PR leverages the existing logic in
ICommand tapOutsideOfPopupCommand